Francesco Romani has posted comments on this change. Change subject: virt: Configurable actions on console disconnect ......................................................................
Patch Set 4: (1 comment) Do we need to update the schema as well? http://gerrit.ovirt.org/#/c/34265/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3769: try: Line 3770: self._dom.updateDeviceFlags(graphics.toxml(), 0) Line 3771: disconnectAction = params.get('disconnectAction', Line 3772: ConsoleDisconnectAction.LOCK_SCREEN) Line 3773: self._consoleDisconnectAction = disconnectAction I believe we could remove this temporary: self._consoleDisconnectAction = params.get( 'disconnectAction', ConsoleDisconnectAction.LOCK_SCREEN) Line 3774: except TimeoutError as tmo: Line 3775: res = {'status': {'code': errCode['ticketErr']['status']['code'], Line 3776: 'message': unicode(tmo)}} Line 3777: else: -- To view, visit http://gerrit.ovirt.org/34265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71d60a38ad89ed942f8e58e985178c27a165c724 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
