Ondřej Svoboda has posted comments on this change. Change subject: networkTests: order VDSM libraries after system libraries ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37035/2/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 26: from nose import with_setup Line 27: from nose.plugins.skip import SkipTest Line 28: Line 29: from vdsm.constants import EXT_BRCTL, EXT_IFUP, EXT_IFDOWN Line 30: from vdsm import ipwrapper > this should be first, empty space before dot My rule was (intuitive): Sort in the order "package, module, module members" (sort of implicitly lexicographical). Hence, vdsm+constants, then vdsm+ipwrapper and later, vdsm+ipwrapper. Line 31: from vdsm.ipwrapper import (routeExists, ruleExists, addrFlush, LinkType, Line 32: getLinks, routeShowTable) Line 33: from vdsm.netinfo import (bridges, operstate, prefix2netmask, getRouteDeviceTo, Line 34: _get_dhclient_ifaces) -- To view, visit http://gerrit.ovirt.org/37035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0172b0813f0719850f80e1cf67d42bffbaa82a7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
