Bala.FA has posted comments on this change. Change subject: gluster: Add geo-replication start and stop session ......................................................................
Patch Set 10: Code-Review-1 (7 comments) http://gerrit.ovirt.org/#/c/17766/10/client/vdsClientGluster.py File client/vdsClientGluster.py: Line 760: 'Returns total, free and used space(bytes) of gluster volume' Line 761: )), Line 762: 'glusterVolumeGeoRepSessionStart': ( Line 763: serv.do_glusterVolumeGeoRepSessionStart, Line 764: ('volumeName=<local_volume_name> ' you could say <volume_name> than <local_volume_name> as it works always with current gluster cluster. Line 765: 'remoteHost=<remote_host_name> ' Line 766: 'remoteVolumeName=<remote_volume_name> ' Line 767: '[force={yes|no}]\n\t' Line 768: '<local_volume_name>existing volume name in the local node\n\t' Line 764: ('volumeName=<local_volume_name> ' Line 765: 'remoteHost=<remote_host_name> ' Line 766: 'remoteVolumeName=<remote_volume_name> ' Line 767: '[force={yes|no}]\n\t' Line 768: '<local_volume_name>existing volume name in the local node\n\t' No need to have this to be described. Line 769: '<remote_host_name>is remote remote host name or ip\n\t' Line 770: '<remote_volume_name>existing volume name in the remote node', Line 771: 'start the geo-replication session' Line 772: )), Line 765: 'remoteHost=<remote_host_name> ' Line 766: 'remoteVolumeName=<remote_volume_name> ' Line 767: '[force={yes|no}]\n\t' Line 768: '<local_volume_name>existing volume name in the local node\n\t' Line 769: '<remote_host_name>is remote remote host name or ip\n\t' please fix this small typo Line 770: '<remote_volume_name>existing volume name in the remote node', Line 771: 'start the geo-replication session' Line 772: )), Line 773: 'glusterVolumeGeoRepSessionStop': ( Line 766: 'remoteVolumeName=<remote_volume_name> ' Line 767: '[force={yes|no}]\n\t' Line 768: '<local_volume_name>existing volume name in the local node\n\t' Line 769: '<remote_host_name>is remote remote host name or ip\n\t' Line 770: '<remote_volume_name>existing volume name in the remote node', 1. have space after <xyz> 2. Have <remote_host_name> as <remote_host> 2. describe <remote_host> is IP/dns name of host in remote Gluster cluster. <remote_volume_name> is a volume name in remote Gluster cluster. Line 771: 'start the geo-replication session' Line 772: )), Line 773: 'glusterVolumeGeoRepSessionStop': ( Line 774: serv.do_glusterVolumeGeoRepSessionStop, Line 777: 'remoteVolumeName=<remote_volume_name> ' Line 778: '[force={yes|no}]\n\t' Line 779: '<local_volume_name>existing volume name in the local node\n\t' Line 780: '<remote_host_name>is remote remote host name or ip\n\t' Line 781: '<remote_volume_name>existing volume name in the remote node', same as above Line 782: 'stop the geo-replication session' Line 783: )), http://gerrit.ovirt.org/#/c/17766/10/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line 1058: Line 1059: @makePublic Line 1060: def volumeGeoRepSessionStart(volumeName, remoteHost, remoteVolumeName, Line 1061: force=False): Line 1062: command = _getGlusterVolCmd() + ["geo-replication", volumeName, Have a function _getGlusterVolGeoRepCmd() which would return _getGlusterVolCmd() + ['geo-replication'] Line 1063: "%s::%s" % (remoteHost, remoteVolumeName), Line 1064: "start"] Line 1065: if force: Line 1066: command.append('force') Line 1076: def volumeGeoRepSessionStop(volumeName, remoteHost, remoteVolumeName, Line 1077: force=False): Line 1078: command = _getGlusterVolCmd() + ["geo-replication", volumeName, Line 1079: "%s::%s" % (remoteHost, remoteVolumeName), Line 1080: "stop"] same here Line 1081: if force: Line 1082: command.append('force') Line 1083: try: Line 1084: _execGlusterXml(command) -- To view, visit http://gerrit.ovirt.org/17766 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cf03c748cf9fe28efe7d407727cd52da20701c5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Better Saggi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Humble Devassy Chirammal <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
