Nir Soffer has posted comments on this change. Change subject: schedule: Introduce scheduling library ......................................................................
Patch Set 23: (2 comments) http://gerrit.ovirt.org/#/c/29607/23/lib/vdsm/schedule.py File lib/vdsm/schedule.py: Line 109: Line 110: Returns a ScheduledCall that may be canceled if callable was not called Line 111: yet. Line 112: """ Line 113: deadline = time.time() + delay > now we can use monotonic_time(), just in case someone plays with the system monotonic_time() resolution is only 10 milliseconds, so this will delay wakeups for no benefit most of the time. System time changes on a machine with ntp are practically non-issue in the context of this scheduler. In python 3, we can use the real thing implemented with clock_gettime instead of our os.times hack. Line 114: call = ScheduledCall(callable) Line 115: with self._cond: Line 116: if not self._running: Line 117: raise AssertionError("Scheduler not running") Line 123: Line 124: @utils.traceback(on=_log.name) Line 125: def _run(self): Line 126: try: Line 127: self._log.debug("started") > strictly speaking, first log should be out of the try block Done Line 128: self._loop() Line 129: self._log.debug("stopped") Line 130: finally: Line 131: self._cancel_calls() -- To view, visit http://gerrit.ovirt.org/29607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3764806d93bd37c3b5924080eb5ae4d29e4f4e0 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: jian wang <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
