Darshan N has posted comments on this change. Change subject: gluster: volume snapshot list and snapshot list verbs. ......................................................................
Patch Set 9: (5 comments) http://gerrit.ovirt.org/#/c/36087/9/vdsm/gluster/apiwrapper.py File vdsm/gluster/apiwrapper.py: Line 188: def snapshotDelete(self, volumeName): Line 189: return self._gluster.volumeSnapshotDelete(volumeName) Line 190: Line 191: def snapshotList(self, volumeName): Line 192: return self._gluster.VolumeSnapshotList(volumeName) > camelCase for "VolumeSnapshotList" ?? Done Line 193: Line 194: Line 195: class GlusterSnapshot(GlusterApiBase): Line 196: def __init__(self): http://gerrit.ovirt.org/#/c/36087/9/vdsm/gluster/cli.py File vdsm/gluster/cli.py: Line 1135: snapshot = {} Line 1136: snapshot['uuid'] = el.find('uuid').text Line 1137: snapshot['description'] = "" if el.find( Line 1138: 'description' Line 1139: ) is None else el.find('description').text > Can we format this line better to align if-else properly ? Done Line 1140: snapshot['createTime'] = el.find('createTime').text Line 1141: snapshot['volCount'] = el.find('volCount').text Line 1142: snapVolumes = [] Line 1143: originVolumes = [] Line 1177: snapshot = {} Line 1178: snapshot['uuid'] = el.find('uuid').text Line 1179: snapshot['description'] = "" if el.find( Line 1180: 'description' Line 1181: ) is None else el.find('description').text > as above Done Line 1182: snapshot['createTime'] = el.find('createTime').text Line 1183: snapshot['volCount'] = el.find('volCount').text Line 1184: snapVolumes = [] Line 1185: originVolumes = [] http://gerrit.ovirt.org/#/c/36087/9/vdsm/gluster/exception.py File vdsm/gluster/exception.py: Line 532: Line 533: Line 534: class GlusterVolumeSnapshotListFailedException(GlusterVolumeException): Line 535: code = 4709 Line 536: message = "volume Snapshot list failed" > "v" capital ? Done http://gerrit.ovirt.org/#/c/36087/9/vdsm/rpc/vdsmapi-gluster-schema.json File vdsm/rpc/vdsmapi-gluster-schema.json: Line 1305: 'data': {'snapName': 'str'}, Line 1306: 'returns': 'bool'} Line 1307: Line 1308: ## Line 1309: # @SnapVolumeInfo: > SnapVolumeStatusInfo ?? Done Line 1310: # Line 1311: # status info of snapshot volume Line 1312: # Line 1313: # @name: name of the snapshot volume -- To view, visit http://gerrit.ovirt.org/36087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06945d6781432b7fb40e417dd21c0ecf107de132 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
