Petr Horáček has posted comments on this change. Change subject: Handle bridge reconfiguration ......................................................................
Patch Set 5: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/37059/5//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-01-22 09:12:58 +0200 Line 6: Line 7: Handle bridge reconfiguration Line 8: Line 9: This fixes a regression that was introduced in double space Line 10: 3951f078d840f6c99d3e72b8ef95a94c6fad4094. When a bridged is reconfigured, for Line 11: example, changing it's IP or it's bootproto, vdsm would change nothing, Line 12: since it would try to leave the bridge intact. Comparing the required configuration Line 13: (setupNetworks arguments) to the running configuration solves this. Line 6: Line 7: Handle bridge reconfiguration Line 8: Line 9: This fixes a regression that was introduced in Line 10: 3951f078d840f6c99d3e72b8ef95a94c6fad4094. When a bridged is reconfigured, for bridged network? Line 11: example, changing it's IP or it's bootproto, vdsm would change nothing, Line 12: since it would try to leave the bridge intact. Comparing the required configuration Line 13: (setupNetworks arguments) to the running configuration solves this. Line 14: Line 7: Handle bridge reconfiguration Line 8: Line 9: This fixes a regression that was introduced in Line 10: 3951f078d840f6c99d3e72b8ef95a94c6fad4094. When a bridged is reconfigured, for Line 11: example, changing it's IP or it's bootproto, vdsm would change nothing, its Line 12: since it would try to leave the bridge intact. Comparing the required configuration Line 13: (setupNetworks arguments) to the running configuration solves this. Line 14: Line 15: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1184497 -- To view, visit http://gerrit.ovirt.org/37059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia461004eb59d10283ac893dc8b5858388d5c4a8c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
