Dan Kenigsberg has posted comments on this change.

Change subject: netlink: event monitor with timeout
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/37129/5/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:

Line 79:     mon = Monitor(groups=('link', 'ipv4-route'))
Line 80:     mon.start()
Line 81:     for event in mon:
Line 82:         if foo:
Line 83:             mon.stop()
handling the even is still needed. why drop it from the example?
Line 84: 
Line 85:     Possible groups: link, notify, neigh, tc, ipv4-ifaddr, ipv4-mroute,
Line 86:     ipv4-route ipv6-ifaddr, ipv6-mroute, ipv6-route, ipv6-ifinfo,
Line 87:     decnet-ifaddr, decnet-route, ipv6-prefix


-- 
To view, visit http://gerrit.ovirt.org/37129
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5a00814d8b7d9c4c7cba52c81b6e56f50dcc584
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to