Nir Soffer has posted comments on this change. Change subject: virt: add ExpiringSet ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/36716/4/tests/vmUtilsTests.py File tests/vmUtilsTests.py: Line 26: Line 27: class TestExpiringSet(TestCaseBase): Line 28: def setUp(self): Line 29: self._counter = itertools.count(0) Line 30: self.es = utils.ExpiringSet( es is a hard to read name. Isn't this a cache? Line 31: maxage=10, Line 32: timefn=lambda: next(self._counter)) Line 33: Line 34: def test_empty(self): -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches