Dan Kenigsberg has posted comments on this change. Change subject: netlink: replace ipwrapper monitor ......................................................................
Patch Set 5: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/37239/5/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 194: try: Line 195: with monitor.Monitor(groups=('link',)) as mon: Line 196: yield Line 197: finally: Line 198: changes = [(event['name'], event['state']) for event in mon hmmm, I don't think we should do this in case of an in-context exception. There's no need to hide the internal exception. Consider dropping the "try-finally" (in another patch). Line 199: if event['name'] == device] Line 200: for _, state in changes: Line 201: if state != originalState: Line 202: raise OperStateChangedError('%s operstate changed: %s -> %r' % -- To view, visit http://gerrit.ovirt.org/37239 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife2ee7d16c79eea7c8ed1f0780aafbaa00356978 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches