Francesco Romani has posted comments on this change. Change subject: hostdev: add dynamic udev rule creation for iommu groups ......................................................................
Patch Set 8: Code-Review+1 (1 comment) Thanks for the updated commit message. As said in review of version 6 and 7, I'm ok with this patch. Added a note about possible improvements. Not sure it is a real issue and/or I'm overthinking, so +1 anyway. http://gerrit.ovirt.org/#/c/36268/8/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 313: """ Line 314: rule = os.path.join(_UDEV_RULE_FILE_DIR, _UDEV_RULE_FILE_PREFIX + Line 315: "iommu_group_" + iommu_group + _UDEV_RULE_FILE_EXT) Line 316: self.log.debug("Removing rule %s", rule) Line 317: os.remove(rule) sorry for (VERY) late noticing but can this possibly remove a rule added by someone else? Do we need some extra care? Line 318: Line 319: @logDecorator Line 320: def ksmTune(self, tuningParams): Line 321: ''' -- To view, visit http://gerrit.ovirt.org/36268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieac8d58e01d7277e535a2101d522961816ea88eb Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
