Dan Kenigsberg has posted comments on this change. Change subject: executor: avoid to notify() busy workers ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/37326/3/lib/vdsm/executor.py File lib/vdsm/executor.py: Line 240: # just want to avoid to have indefinite amount of tasks. Line 241: if len(self._tasks) == self._max_tasks: Line 242: raise TooManyTasks() Line 243: self._tasks.append(task) Line 244: if self._waiters > 0: race: if another thread running get() is just past line 256, _waiters is 0, and we won't notify it. Line 245: with self._cond: Line 246: self._cond.notify() Line 247: Line 248: def get(self): -- To view, visit http://gerrit.ovirt.org/37326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia197ee8bdeea3e1a353fc9fa5953788d95d53581 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
