Timothy Asir has posted comments on this change. Change subject: Add feature to create dispersed volume ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/37474/3/vdsm/rpc/vdsmapi-gluster-schema.json File vdsm/rpc/vdsmapi-gluster-schema.json: Line 666: # Line 667: # Since: 4.17.0 Line 668: ## Line 669: {'type': 'VolumeXtraParms', Line 670: 'data': {'*disperseCount': 'int', '*redundancyCount': 'int'}} > Here we have inconsistency between the name in description and in type defi Done Line 671: Line 672: ## Line 673: # @GlusterVolume.create: Line 674: # Line 694: # Since: 4.10.3 Line 695: ## Line 696: {'command': {'class': 'GlusterVolume', 'name': 'create'}, Line 697: 'data': {'volumeName': 'str', 'bricklist': ['str'], Line 698: '*replicaCount': 'int', '*stripeCount': 'int', > Please update *Count name here as well. Done Line 699: '*transportList': ['transType'], '*force': 'bool', Line 700: '*options': 'VolumeXtraParms'}, Line 701: 'returns': 'UUID'} Line 702: -- To view, visit http://gerrit.ovirt.org/37474 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I50f6dbae8d179c09480634c64d7d439ae82d72a2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Bala.FA <barum...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
