Dan Kenigsberg has posted comments on this change. Change subject: hostdev: add support for reporting usb addresses ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/35785/7/vdsm/hostdev.py File vdsm/hostdev.py: Line 75: also doing sysfs lookups for sr-iov related information Line 76: """ Line 77: address_parser = {'pci': _parse_pci_address, Line 78: 'scsi': _parse_scsi_address, Line 79: # We have to use usb_device here in order to reflect this comment sounds a bit tautological. The funny name of "usb_device" is not really unique to this commit. It was introduced much earlier (it's already documented in the schema). If a comment is needed, it should be in schema or git commit message, and say that usb_device is the libvirt standard. Line 80: # usb_device, which is the capability of device we want Line 81: # to actually pass through. Line 82: 'usb_device': _parse_usb_address} Line 83: -- To view, visit http://gerrit.ovirt.org/35785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d4a4e1d3703abd25c9fa0584ec0e0a1d52b685c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
