Ondřej Svoboda has posted comments on this change. Change subject: networkTests: do not confuse dhclient with invalid configuration ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37040/1/tests/functional/dhcp.py File tests/functional/dhcp.py: Line 104: # Instruct Fedora/EL's dhclient-script not to set gateway on iface Line 105: cmd += ['-e', 'DEFROUTE=no'] Line 106: self._cmd = cmd + [self._interface] Line 107: Line 108: def _create_conf(self): > the Okay, creating an empty file simplifies the matter :-) Line 109: with open(self._conf_file, 'w') as f: Line 110: f.write('db-time-format {0};'.format(self._date_format)) Line 111: Line 112: def start(self): -- To view, visit http://gerrit.ovirt.org/37040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cb1430aa7ba101c0fbc2e74094814fbcd7b50d6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
