Nir Soffer has posted comments on this change. Change subject: vm: Fix extend size calculation ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37274/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1454: return capacity, alloc, physical Line 1455: Line 1456: def _shouldExtendVolume(self, drive, volumeID, capacity, alloc, physical): Line 1457: nextSize = vmdevices.storage.getNextVolumeSize( Line 1458: physical, capacity, drive.volExtensionChunk) If nextSize == curSize, log warning about drive becoming full and return False. This code is attempting to extend drive to the same size, which will fail on the spm side when invoking lvm. This is pointless and create bogus lvm failures. Line 1459: nextPhysSize = nextSize * constants.MEGAB Line 1460: Line 1461: # NOTE: the intent of this check is to prevent faulty images to Line 1462: # trick qemu in requesting extremely large extensions (BZ#998443). -- To view, visit http://gerrit.ovirt.org/37274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7afe3a7f6cfbb47eb76249d3851b7adaf4dbba6f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
