Bala.FA has posted comments on this change.

Change subject: gluster: volume snapshot config list and set verbs.
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/34741/8//COMMIT_MSG
Commit Message:

Line 15: Returns:
Line 16:     {'systemConfig':{'snap-max-hard-limit': 'hardLimit',
Line 17:                      'snap-max-soft-limit': 'softLimit',
Line 18:                      'auto-delete': 'enable/disable'},
Line 19:      'volumeConfig':{'volume name': {
How about 'system' instead of 'systemConfig' and 'volume' instead of 
'volumeConfig'?
Line 20:                           'snap-max-hard-limit': 'hardLimit'}...
Line 21:                     }
Line 22:     }
Line 23: 


-- 
To view, visit http://gerrit.ovirt.org/34741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee32a95cf028cda33f25776c08820c5ed80f1033
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to