Nir Soffer has posted comments on this change. Change subject: profile: transform into a subpackage ......................................................................
Patch Set 6: (4 comments) I think that just making it a package without the profile.py facade makes more sens now. http://gerrit.ovirt.org/#/c/36010/6/lib/vdsm/profiling/__init__.py File lib/vdsm/profiling/__init__.py: Line 15: # along with this program; if not, write to the Free Software Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Empty file do not need a license. http://gerrit.ovirt.org/#/c/36010/6/lib/vdsm/profiling/profile.py File lib/vdsm/profiling/profile.py: Line 33: cpu.stop() Line 34: Line 35: Line 36: def is_enabled(): Line 37: return cpu.is_enabled() When we have both memory and cpu profilers, and only one of them is enabled, what should be the return value? Line 38: Line 39: Line 40: def is_running(): Line 37: return cpu.is_enabled() Line 38: Line 39: Line 40: def is_running(): Line 41: return cpu.is_running() Same Do we need is_enabled and is_running in this facade? Maybe the addition of this facade should be done when you add the memory profiler, as it looks a little bit pointless now. http://gerrit.ovirt.org/#/c/36010/6/tests/profileTests.py File tests/profileTests.py: Line 15 Line 16 Line 17 Line 18 Line 19 This should be cpuProfileTests.py now. -- To view, visit http://gerrit.ovirt.org/36010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfd925e566a9af69d4b42a70fa835b072bb1f7a0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
