David Caro has posted comments on this change.
Change subject: tests: profile: use make_config from testlib
......................................................................
Patch Set 4:
This change broke the pyflakes tests, and thus the rpmbuild, please fix asap
python -c 'import pyflakes; print("pyflakes-%s" % pyflakes.__version__)'
pyflakes-0.7.3
( find . -path './.git' -prune -type f -o \
-path './vdsm_compat' -prune -type f -o \
-name '*.py' -o -name '*.py.in' && \
echo contrib/profile-stats init/daemonAdapter vdsm/get-conf-item
vdsm/set-conf-item vdsm/supervdsmServer vdsm/vdsm vdsm/vdsm-restore-net-config
vdsm/storage/curl-img-wrap vdsm/storage/fc-scan vdsm-tool/vdsm-tool
vds_bootstrap/setup vdsm_reg/vdsm-reg-setup.in ) | xargs /usr/bin/pyflakes | \
grep -w -v "\./vdsm/storage/lvm\.py.*: list comprehension redefines
'lv' from line .*" | \
while read LINE; do echo "$LINE"; false; done
./tests/profileTests.py:21: 'ConfigParser' imported but unused
./tests/profileTests.py:29: 'config' imported but unused
make: *** [pyflakes] Error 1
--
To view, visit http://gerrit.ovirt.org/36579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee786163d9e8543109b3e6de9863d892e34ae903
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
