Yaniv Bronhaim has posted comments on this change. Change subject: infra: Introduce EventFD support ......................................................................
Patch Set 3: Code-Review-1 (3 comments) dont you need to add it to the spec as well? http://gerrit.ovirt.org/#/c/37051/3/lib/vdsm/infra/eventfd/__init__.py File lib/vdsm/infra/eventfd/__init__.py: Line 37: Line 38: libc = ctypes.CDLL("libc.so.6", use_errno=True) Line 39: Line 40: EFD_SEMAPHORE = 00000001, Line 41: EFD_CLOEXEC = 02000000, as for todo, please add # os.O_CLOEXEC in python 3.3 Line 42: EFD_NONBLOCK = 00004000 Line 43: Line 44: Line 45: class EventFD(object): Line 38: libc = ctypes.CDLL("libc.so.6", use_errno=True) Line 39: Line 40: EFD_SEMAPHORE = 00000001, Line 41: EFD_CLOEXEC = 02000000, Line 42: EFD_NONBLOCK = 00004000 use os.O_NONBLOCK Line 43: Line 44: Line 45: class EventFD(object): Line 46: """ Line 93: msg = os.strerror(err) Line 94: raise OSError(err, msg) Line 95: Line 96: return int(n.value) Line 97: why not adding poll also? Line 98: def write(self, value=1): Line 99: """ Line 100: A write() call adds the integer value to the counter. The maximum Line 101: value that may be stored in the counter is the largest unsigned 64-bit -- To view, visit http://gerrit.ovirt.org/37051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6035d4a8dc13ce11cf0425e4945bbf0c19bd92a7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
