Ondřej Svoboda has uploaded a new change for review.

Change subject: netinfo: do not report DHCP from (typically still valid) leases
......................................................................

netinfo: do not report DHCP from (typically still valid) leases

Although I introduced this behaviour intentionally, VDSM must stop reporting
dhcpv4 and dhcpv6 for a network that is reverted to static configutation
(which is to be effective immediately not to confuse the engine and the user).

Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599
Signed-off-by: Ondřej Svoboda <[email protected]>
---
M tests/functional/networkTests.py
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/37617/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 37feeb2..acaf7fe 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -1818,6 +1818,15 @@
                         self.assertSourceRoutingConfiguration(device_name,
                                                               ip_addr)
 
+                    # Do not report DHCP from (typically still valid) leases
+                    network[NETWORK_NAME]['bootproto'] = 'none'
+                    status, msg = self.vdsm_net.setupNetworks(network, {},
+                                                              NOCHK)
+                    self.assertEqual(status, SUCCESS, msg)
+                    test_net = self.vdsm_net.netinfo.networks[NETWORK_NAME]
+                    self.assertEqual(test_net['dhcpv4'], False)
+                    self.assertEqual(test_net['dhcpv6'], False)
+
                     network = {NETWORK_NAME: {'remove': True}}
                     status, msg = self.vdsm_net.setupNetworks(network, {},
                                                               NOCHK)


-- 
To view, visit http://gerrit.ovirt.org/37617
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to