Francesco Romani has posted comments on this change. Change subject: RFE: Report downtime for each live migration ......................................................................
Patch Set 1: (1 comment) I know this is a WIP, but I had a quick look and noticed a simple silly thing. http://gerrit.ovirt.org/#/c/37075/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1800: t I know this is WIP, but still worth mentioning. Albeit should be cheap, it is wasteful to call migrateStatus twice here. Let's just do: migStatus = self.migrateStatus() stats['migrationProgress'] = migStatus['progress'] stats['migrationDowntime'] = migStatus['downtime'] -- To view, visit http://gerrit.ovirt.org/37075 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
