Francesco Romani has posted comments on this change. Change subject: virt: Add Drive.extendable property ......................................................................
Patch Set 3: Code-Review+1 (1 comment) I tend to like and support everything that makes the Vm class and vm.py shorter :) http://gerrit.ovirt.org/#/c/37570/3/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 149: Return True if drive supports extending. Line 150: Line 151: If a drive is extendable, current drive write watermark and Line 152: Drive.volExtensionChunk is used to detect if a drive should be Line 153: extended, and getNextVolumeSize to find the new size. I wonder if this documentation really belongs there or if it should be moved closer to the implementation. Line 154: """ Line 155: return self.blockDev and self.format == "cow" Line 156: Line 157: @property -- To view, visit http://gerrit.ovirt.org/37570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
