Nir Soffer has posted comments on this change. Change subject: virt: add ExpiringCache ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/36716/10/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 77: Line 78: def __getitem__(self, key): Line 79: """ Line 80: Raises KeyError if a key was not found. Line 81: Raises ItemExpired if a a key expired and was cleaned up. Still with double a? I think this can be nicer as a single paragraph: If no item is stored for key, raises KeyError. If an item expired, raises ItemExpired (a subclass of KeyError). Line 82: ItemExpired is a subclass of KeyError. Line 83: """ Line 84: return self._get_live(key) Line 85: -- To view, visit http://gerrit.ovirt.org/36716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
