Shahar Havivi has posted comments on this change. Change subject: v2v: additional info for disk and network ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37655/2/vdsm/v2v.py File vdsm/v2v.py: Line 132: params['disks'] = [] Line 133: disks = root.findall('.//disk[@type="file"]') Line 134: for disk in disks: Line 135: d = {} Line 136: if disk.get('device') is not None: > let's just use Done Line 137: d['type'] = disk.get('device') Line 138: target = disk.find('./target/[@dev]') Line 139: if target is not None: Line 140: d['dev'] = target.get('dev') -- To view, visit http://gerrit.ovirt.org/37655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
