Ondřej Svoboda has posted comments on this change. Change subject: networkTests: delete our lease files also on EL6 ......................................................................
Patch Set 2: Verified+1 There are no leftover leases even on EL6. ==== not related to the verification: I only noticed that testSetupNetworksReconfigureBridge shows a warning although it succeeds: WARNING:root:File: /var/lib/dhclient/dhclient-test-network.leases already removed I think that the try-finally block in the test can be simplified – it just needs to wrap setup_test_network(dhcp=True), only one such call. -- To view, visit http://gerrit.ovirt.org/37684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe9bd81c33aade9baf72c54f25a802f80a36de5a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
