Dan Kenigsberg has submitted this change and it was merged. Change subject: qemu-img: check/use "-T src_cache" option in convert/rebase when available ......................................................................
qemu-img: check/use "-T src_cache" option in convert/rebase when available "qemu-img" is used for operations like disk move or snapshot delete. This process reads data using the hypervisor page cache. As this data might be hotter than any VM memory the system starts swapping out memory pages of the running VMs. vdsm already uses "-t none" option to avoid cache for output image. Now "qemu-img" introduced a new "-T src_cache" to avoid cache for the input image (bz#1116558). This patch is testing if qemu-img has the new "-T src_cache" option available for convert and rebase commands and using it with "-T none" when true. Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1138690 Signed-off-by: Amador Pahim <apa...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/36308 Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Federico Simoncelli <fsimo...@redhat.com> --- M lib/vdsm/qemuimg.py M tests/qemuimgTests.py 2 files changed, 102 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Federico Simoncelli: Looks good to me, approved Amador Pahim: Verified -- To view, visit http://gerrit.ovirt.org/36308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
