Nir Soffer has posted comments on this change. Change subject: tests: clear libvirtconnection cache ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/37747/2//COMMIT_MSG Commit Message: Line 8: Line 9: the libvirtconnection has a connection cache, Line 10: and this caching doesn't play well with the monkeypatching Line 11: which we do in tests. This leads to fake libvirt objects Line 12: persist in the python process. Please explain the nature of this error: we create a fake virConnect object in one test, and the fake object is cached by the module and returned on the next calls, breaking tests that exepct the real object. Line 13: Line 14: This failure is evident only during 'make check'-like runs, Line 15: when global state is preserved across test suites. Line 16: Line 28: memInfo = caps.getMemoryStatsByNumaCell(int(nodeIndex)) Line 29: File "/root/src/vdsm/vdsm/caps.py", line 358, in Line 30: getMemoryStatsByNumaCell Line 31: cellMemInfo = conn.getMemoryStats(cell, 0) Line 32: AttributeError: 'virConnect' object has no attribute 'getMemoryStats' It is good to show the error so people getting this error know that it was fixed by this patch, but the traceback is not needed. Line 33: Line 34: This patch fixes this error clearing the libvirtconnection cache Line 35: after each test. Line 36: -- To view, visit http://gerrit.ovirt.org/37747 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4d64920e5f26c276accf26b7a532461d04f02df Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
