Ondřej Svoboda has uploaded a new change for review. Change subject: api: pass parameters to IpConfig as positional ......................................................................
api: pass parameters to IpConfig as positional None of them are left out or out of order and using keyword parameters here is confusing. Change-Id: Ia9a934e7bcb9f047265477dada3d1ef8ceadf83c Signed-off-by: Ondřej Svoboda <[email protected]> --- M vdsm/network/api.py 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/37787/1 diff --git a/vdsm/network/api.py b/vdsm/network/api.py index 6841a62..58a91ff 100755 --- a/vdsm/network/api.py +++ b/vdsm/network/api.py @@ -163,10 +163,9 @@ 'devices.') ipv6 = IPv6(ipv6addr, ipv6gateway, defaultRoute) ipv4 = IPv4(ipaddr, netmask, gateway, defaultRoute) - topNetDev.ip = IpConfig( - ipv4=ipv4, ipv6=ipv6, bootproto=bootproto, - blocking=(configurator._inRollback or utils.tobool(blockingdhcp)), - ipv6autoconf=ipv6autoconf, dhcpv6=dhcpv6) + blocking = configurator._inRollback or utils.tobool(blockingdhcp) + topNetDev.ip = IpConfig(ipv4, ipv6, bootproto, blocking, ipv6autoconf, + dhcpv6) return topNetDev -- To view, visit http://gerrit.ovirt.org/37787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9a934e7bcb9f047265477dada3d1ef8ceadf83c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
