Saggi Mizrahi has posted comments on this change. Change subject: betterAsyncore: Bind the dispatcher implementation ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/35252/5/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 264: "readable", Line 265: "writable", Line 266: ): Line 267: method = getattr( Line 268: self.__impl, > but before if the attr was not there you got it from self.__impl.. why do y I don't understand the comment. This does the exact same thing as before just on construction instead of on every call. Line 269: attr_name, Line 270: getattr( Line 271: asyncore.dispatcher, Line 272: attr_name -- To view, visit http://gerrit.ovirt.org/35252 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If24df908104e3bf4e991f7b21b3459646286f581 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
