Nir Soffer has posted comments on this change. Change subject: ceph: Quick and dirty prototype ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36872/2/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 54: def __new__(cls, conf, log, **kwargs): Line 55: """ Line 56: Create the required drive subclass using "diskType" attribute. Line 57: Line 58: For example: "network" -> NetworkDrive This can be nice to clean up the code - but does not play well with lsm between different storage types - when moving from file to block, blockDev is invalidated automatically, and drive changes its diskType from "file" to "block". Using separate classes, this will not work, and we will have to replace the drive object in the vm conf, or change the design so anything related to drive type is in a DriveType object, and Drive delegate to it when needed. Line 59: """ Line 60: diskType = kwargs.get("diskType", "legacy") Line 61: className = diskType.capitalize() + "Drive" Line 62: driveClass = globals()[className] -- To view, visit http://gerrit.ovirt.org/36872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1aa096ef01bca66db0e6796a54eb573ddeb43865 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
