Ondřej Svoboda has posted comments on this change. Change subject: network: api: allow removal of bond with no slaves ......................................................................
Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/37751/5//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-02-17 16:02:50 +0100 Line 6: Line 7: network: api: allow removal of bond with no slaves Line 8: Line 9: If we try to remove bond with no attached slaves, VDSM explodes and a bond, no slaves attached (somehow I prefer inverted word order here) Line 10: don't allow us to repair the network. Line 11: Line 12: With this patch, slaves checking is moved upper, only to 'edit' and Line 13: 'add' bond's functions. Line 6: Line 7: network: api: allow removal of bond with no slaves Line 8: Line 9: If we try to remove bond with no attached slaves, VDSM explodes and Line 10: don't allow us to repair the network. doesn't Line 11: Line 12: With this patch, slaves checking is moved upper, only to 'edit' and Line 13: 'add' bond's functions. Line 14: Line 8: Line 9: If we try to remove bond with no attached slaves, VDSM explodes and Line 10: don't allow us to repair the network. Line 11: Line 12: With this patch, slaves checking is moved upper, only to 'edit' and This patch moves checking of slaves up the stack (better than "upper"?) Line 13: 'add' bond's functions. Line 14: Line 15: 'remove' bond function is able to objectivize slaveless bond and allows us Line 16: to remove it. -- To view, visit http://gerrit.ovirt.org/37751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b472305c00e3f11a4f7ede78f84eea589ca616b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
