Nir Soffer has posted comments on this change. Change subject: profiling: import yappi outside lock ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/37915/2//COMMIT_MSG Commit Message: Line 9: Importing modules with locks held is dangerous and Line 10: may lead to deadlock. Line 11: Better to move the import of the yappi module outside the lock. Line 12: Line 13: No changes in behaviour are meant. Does not change the behavior? Line 14: Line 15: Change-Id: I31d69a70efce2348e2b74e5d8a20e81b2c598321 -- To view, visit http://gerrit.ovirt.org/37915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31d69a70efce2348e2b74e5d8a20e81b2c598321 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
