Francesco Romani has posted comments on this change.

Change subject: profiling: disambiguate profile identifiers
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.ovirt.org/#/c/36011/8/lib/vdsm/profiling/cpu.py
File lib/vdsm/profiling/cpu.py:

Line 32: 
Line 33: # Import yappi lazily when profile is started
Line 34: yappi = None
Line 35: 
Line 36: NAME = "cpu"
> We don't use this in this patch - right?
Good point, no need to mess up things. Ill move in the patch which adds 
'status' to the facade.
Line 37: 
Line 38: # Defaults
Line 39: 
Line 40: _FILENAME = os.path.join(constants.P_VDSM_RUN, 'vdsmd.prof')


-- 
To view, visit http://gerrit.ovirt.org/36011
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43159009318295313855a16688b249982e40b34
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to