Nir Soffer has uploaded a new change for review. Change subject: virt: Continue to collect extend candidates after errors ......................................................................
virt: Continue to collect extend candidates after errors Previously, if we had one bad drive that libvirt fail to get watermarks, we would stop collecting extend candidates and log a traceback. This would cause a vm to pause, since we may never extend any of its disks, and the log would be littered with unhelpful tracebacks. Now we log an error in such case and continue to collect extend candidates, so error with one disk cannot effect other disks. Change-Id: I5d321001d096c45f5b78982c3c0f225728bd4184 Signed-off-by: Nir Soffer <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/38045/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 18cb0d3..8c4df53 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -1406,7 +1406,13 @@ if not drive.chunked: continue - capacity, alloc, physical = self._dom.blockInfo(drive.path, 0) + try: + capacity, alloc, physical = self._dom.blockInfo(drive.path, 0) + except libvirt.libvirtError as e: + self.log.error("Unable to get watermarks for drive %s: %s", + drive.name, e) + continue + ret.append((drive, drive.volumeID, capacity, alloc, physical)) try: -- To view, visit http://gerrit.ovirt.org/38045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5d321001d096c45f5b78982c3c0f225728bd4184 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
