Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: convert yes/no <-> True/False using _from_ifcfg_bool and _to_ifcfg_bool ......................................................................
Patch Set 5: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/37792/5/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 615: opts['hotplug'] = 'no' # So that udev doesn't trigger an ifup Line 616: if bridge.stp is not None: Line 617: conf += 'STP=%s\n' % ('on' if bridge.stp else 'off') Line 618: if not self.unifiedPersistence or bridge.ipConfig.defaultRoute: Line 619: conf += 'ONBOOT=%s\n' % 'yes' for a future patch: replace these conditions with calls to _to_ifcfg_bool() Line 620: else: Line 621: conf += 'ONBOOT=%s\n' % 'no' Line 622: Line 623: if 'custom' in opts and 'bridge_opts' in opts['custom']: -- To view, visit http://gerrit.ovirt.org/37792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87069ee99fb39d4ce100ccc03117c5a7c88b3e96 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
