Dan Kenigsberg has posted comments on this change. Change subject: vm: add an API to check if the domain is busy ......................................................................
Patch Set 19: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36721/19/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2955: # so no worries. Line 2956: Line 2957: return 'NOERR' Line 2958: Line 2959: def isDomainResponsive(self): This returns false if a random command is executed by qemu right now. vdsm's "responsive" is something a bit different - that recently, we did not get a timely response from qemu. We should find a better name for this method. How about is_occupied? Line 2960: """ Line 2961: Return true if the domain monitor is ready to accept commands, Line 2962: false otherwise. Line 2963: """ -- To view, visit http://gerrit.ovirt.org/36721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa253326778a102591af4ef5f2bb0434d1eade6 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
