Nir Soffer has posted comments on this change. Change subject: virt: Allocate additonal space for cow internal data ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38178/2/vdsm/virt/vmdevices/storage.py File vdsm/virt/vmdevices/storage.py: Line 51: VOLWM_FREE_PCT = 100 - config.getint('irs', 'volume_utilization_percent') Line 52: VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during replication Line 53: Line 54: # Estimate of the additional space needed for qcow format internal data. Line 55: VOLWM_COW_OVERHEAD = 1.1 > does it make sense to avoid floats here? We usually try to avoid them. I pe What wrong with floats? How do you suggest to avoid them for adding 10% to a size? This is the same logic as in vdsm/storage/image.py - look for "1.1" (I will clean the mess later). Line 56: Line 57: def __init__(self, conf, log, **kwargs): Line 58: if not kwargs.get('serial'): Line 59: self.serial = kwargs.get('imageID'[-20:]) or '' -- To view, visit https://gerrit.ovirt.org/38178 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
