Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: Fix LSM when using libvirt >= 1.2.8 ......................................................................
vm: Fix LSM when using libvirt >= 1.2.8 Libvirt 1.2.8 introduced a regression where disk type is converted from "block" to "file" after blockRebase. This breaks our extend logic, leading to unwanted extension of up to the disk virtual size, practically making it preallocated. In 3.5, this used to extend the disk without limit using all free space on the vg. Libvirt 1.2.9 introduced a new VIR_DOMAIN_BLOCK_REBASE_COPY_DEV flag for fixing this issue. This flag must be used when calling blockRebase with block-based disk. This fix was backported to EL7.1 in libvirt-1.2.8-16.el7_1.1 and libvirt-python-1.2.8-6.el7_1.1. This patch uses VIR_DOMAIN_BLOCK_REBASE_COPY_DEV when available, fixing this issue in EL7.1 and Fedora 21. Other platforms are not affected by this issue because they are running older libvirt versions. We assume that we are always working with local libvirt daemon, and having the flag in the libvirt python bindings means that libvirt daemon support the flag. Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7 Bug-Url: https://bugzilla.redhat.com/1196049 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/38142 Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Adam Litke <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> Reviewed-on: https://gerrit.ovirt.org/38201 Reviewed-by: Yaniv Bronhaim <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38201 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eric Blake <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
