Dan Kenigsberg has posted comments on this change. Change subject: storageServer: Avoid bogus warnings from createdir ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/36372/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-12-24 00:57:19 +0200 Line 4: Commit: Nir Soffer <[email protected]> Line 5: CommitDate: 2015-02-04 21:34:37 +0200 Line 6: Line 7: storageServer: Avoid bogus warnings from createdir This patch copies bits of fileUtils.createdir() while demoting a warning to debug. I think that what's "bogus" is the fact that we leave stale mountpoint behind. This is long known. Don't you think that this needs fixing? Why? Line 8: Line 9: When using fileUtils.createdir() and the directory already exists, a Line 10: bogus warning is logged. Since we are not specifying a mode, there is no Line 11: need to use this utility. -- To view, visit https://gerrit.ovirt.org/36372 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07db7b1af0b02901a338f649577291f9bc641057 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
