Nir Soffer has posted comments on this change. Change subject: lvm:moved metadatasize as an optional param for pv create in lvm module ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38188/2//COMMIT_MSG Commit Message: Line 9: Specifying the metadata area using metadatasize is not a Line 10: mantatory its just an option to pvcreate command. Line 11: There are some situations like when a volume group contains Line 12: many physical volumes, having many redundant copies of Line 13: metadata (on every physical volume) is inefficient. We do not keep redundant copies of the metadata - the data is kept only on the first pv when you create a vg (--metadataignore y). The metadata area on the next pvs is unused, but having it allows using this area on these pvs later. Since we use 128 megabytes for each metadata area, this change save 256 megabytes per pv, which is not very interesting. Users are heaving terabytes and they do not care about those 256 megabytes. Line 14: Line 15: Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3 -- To view, visit https://gerrit.ovirt.org/38188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f161c0d6996219553c556125a97a01d69a4be3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
