Ondřej Svoboda has posted comments on this change. Change subject: api: correct the order of parameters in _bridge_reconfigured ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38256/1/vdsm/network/api.py File vdsm/network/api.py: Line 753: if k not in ('bonding', 'nic', 'mtu')) Line 754: Line 755: def _bridge_reconfigured(current_conf, required_conf): Line 756: return (_bridge_only_config(current_conf) != Line 757: _bridge_only_config(required_conf)) > nit: why the double change? only line 755 should be changed I wanted to impose the same order both on parameters and on their usage in the function. Personally, I find it easier to read. Line 758: Line 759: if currently_bridged and _bridge_reconfigured(network_running_config, Line 760: network_attrs): Line 761: logging.debug("the bridge is being reconfigured") -- To view, visit https://gerrit.ovirt.org/38256 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2326fffabaffeadc796b492ffe575a669a46b727 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches