Dan Kenigsberg has posted comments on this change. Change subject: hostdev: fix creation and deletion of multiple udev rules ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38208/2/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 313: '/dev/vfio/{}"').format(iommu_group, EXT_CHOWN, Line 314: QEMU_PROCESS_USER, QEMU_PROCESS_GROUP, Line 315: iommu_group) Line 316: Line 317: if not os.path.isfile(ruleFile): this condition can be placed higher. Line 318: # If the file exists, different device from the same group has Line 319: # already been detached and we therefore can skip overwriting the Line 320: # file. Also, this file should only be created/removed via the Line 321: # means of supervdsm, therefore no races should occur. -- To view, visit https://gerrit.ovirt.org/38208 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83fffb2f6e42cc1746f30ca2b63c5d594de014e5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
