Dan Kenigsberg has posted comments on this change. Change subject: virt: Additional reporting of CPU and IO information ......................................................................
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38366/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 560: if 'vcpuLimit' in sample: Line 561: value = sample['vcpuLimit'] Line 562: stats['vcpuUserLimit'] = value Line 563: Line 564: if 'cpu_shares' in sample: I do not think that this is what we need to expose in this context. We need to report the accumulated number of jiffies actually eaten by this VM's CPUs. Not the relative shares allocated for it in advance. I also suggest to separate the cpu-related patch from the storage related one, to simplify review. Line 565: stats['cpuShares'] = sample['cpu_shares'] Line 566: Line 567: def _getNetworkStats(self, stats): Line 568: stats['network'] = {} -- To view, visit https://gerrit.ovirt.org/38366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb0055fcd720a88a96a67e7424007384734a4404 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
