Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Log the the duration time of the migration
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38482/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 330:                 with utils.running(self._monitorThread):
Line 331:                     # we need to support python 2.6, so two nested 
with-s.
Line 332:                     self._perform_migration(duri, muri)
Line 333: 
Line 334:             self.log.debug("migration took %d seconds to complete",
> imho info is better, it's an interesting value not happening too often.
No this won't for that I would have to change the previous patchset to 
calculate the time and then use it here.
Line 335:                            time.time() - startTime)
Line 336: 
Line 337:     def _perform_migration(self, duri, muri):
Line 338:         if self._vm.hasSpice and self._vm.conf.get('clientIp'):


-- 
To view, visit https://gerrit.ovirt.org/38482
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6415dd159c55633e6ed5fd395f6fac38aca69a63
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to