Yaniv Bronhaim has submitted this change and it was merged. Change subject: qemu-img: check/use "-T src_cache" option in convert/rebase when available ......................................................................
qemu-img: check/use "-T src_cache" option in convert/rebase when available "qemu-img" is used for operations like disk move or snapshot delete. This process reads data using the hypervisor page cache. As this data might be hotter than any VM memory the system starts swapping out memory pages of the running VMs. vdsm already uses "-t none" option to avoid cache for output image. Now "qemu-img" introduced a new "-T src_cache" to avoid cache for the input image (bz#1116558). This patch is testing if qemu-img has the new "-T src_cache" option available for convert and rebase commands and using it with "-T none" when true. Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1199141 Signed-off-by: Amador Pahim <[email protected]> Reviewed-on: http://gerrit.ovirt.org/36308 Reviewed-by: Nir Soffer <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-on: https://gerrit.ovirt.org/38434 Reviewed-by: Allon Mureinik <[email protected]> Reviewed-by: Yaniv Bronhaim <[email protected]> --- M lib/vdsm/qemuimg.py 1 file changed, 29 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Amador Pahim: Verified Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e07f182e880f79055e53ef47aa28ddcf9659c45 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
