Michal Skrivanek has posted comments on this change. Change subject: hostdev: add hostdev device definition ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/37700/12/vdsm/virt/vmdevices/hostdevice.py File vdsm/virt/vmdevices/hostdevice.py: Line 67: **self._deviceParams['address']) Line 68: rom = hostdev.appendChildWithArgs('rom') Line 69: romAttrs = {} Line 70: Line 71: if 'bar' in self.specParams: I'd drop it; since it needs to be on all hosts, etc....well, sounds like a hook material Line 72: if self.specParams['bar']: Line 73: romAttrs['bar'] = 'on' Line 74: else: Line 75: romAttrs['bar'] = 'off' -- To view, visit https://gerrit.ovirt.org/37700 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
