Sandro Bonazzola has posted comments on this change.

Change subject: lvm: Add convertLV function in storage.lvm module
......................................................................


Patch Set 2: Verified-1

(1 comment)

Please review also 
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_el_gerrit/15696/console

https://gerrit.ovirt.org/#/c/38557/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:

Line 820: 
Line 821: 
Line 822: def convertLV(attrs):
Line 823:     """
Line 824:     Convert a logical volume from linear to mirror or snapshot 
W291 trailing whitespace
Line 825: 
Line 826:     attrs: an iterable of (attr, value) pairs),
Line 827:             e.g. (('--available', 'y'), ('--permission', 'rw')
Line 828:     """


-- 
To view, visit https://gerrit.ovirt.org/38557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80fe74ed9e61f58f20bd60be46109cce9b06a69c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeya...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to