Eric Blake has posted comments on this change. Change subject: vm: Fix LSM when using libvirt >= 1.2.8 ......................................................................
Patch Set 1: > (1 comment) > > Comment typo in the code, but the logic is correct. Oh, and you also need to be sure that vdsm will never be compiled against newer libvirt-python (that has the constant) while driving older libvirtd (that lacks support for the constant), which may be possible by judicious version dependencies in .spec files. If this is not possible, then you may want to enhance the vm.py file to have a fallback that recognizes the 'unknown flag' error and falls back to trying a second time without the flag, if you ever have a case where the libvirt-python on the client machine making the call is newer than the libvirtd on the server machine implementing the call. -- To view, visit https://gerrit.ovirt.org/38142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eric Blake <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
