Piotr Kliczewski has uploaded a new change for review.

Change subject: jsonrpc: regression on setupNetworks
......................................................................

jsonrpc: regression on setupNetworks

During schema and code alignemnt Host_setupNetowrks entry was removed
from command_info. Adding back the entry and fixing schema verification
test.


Bug-Url: https://bugzilla.redhat.com/1178536
Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Signed-off-by: pkliczewski <[email protected]>
---
M tests/schemaValidationTest.py
M vdsm/rpc/Bridge.py
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/36612/1

diff --git a/tests/schemaValidationTest.py b/tests/schemaValidationTest.py
index d995a7f..43e061e 100644
--- a/tests/schemaValidationTest.py
+++ b/tests/schemaValidationTest.py
@@ -125,6 +125,8 @@
                     ret_info = Bridge.command_info.get(cmd, {}).get('ret')
                     if not ret_info and not ret:
                         continue
+                    if ret_info == 'status':
+                        continue
                     if not ret_info or not ret:
                         raise AssertionError('wrong return type for ' + cmd)
                 except KeyError:
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index f8c06f6..f1f6f31 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -418,6 +418,7 @@
     'Host_getVMList': {'call': Host_getVMList_Call, 'ret': Host_getVMList_Ret},
     'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
     'Host_getAllVmStats': {'ret': 'statsList'},
+    'Host_setupNetworks': {'ret': 'status'},
     'Image_cloneStructure': {'ret': 'uuid'},
     'Image_delete': {'ret': 'uuid'},
     'Image_deleteVolumes': {'ret': 'uuid'},


-- 
To view, visit http://gerrit.ovirt.org/36612
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I41c304d70f1040eac6a2098d8ab9734fd1115e61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to