Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: report a gateway for statically configured networks ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/37440/1/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 614: # which the source route thread manages routing in a separate table (with Line 615: # an ID currently derived from the interface's address) we have to look in Line 616: # all tables. Line 617: gateways = [r for r in routes if r['destination'] == 'none' and Line 618: (r.get('table') == table or dev) and r['scope'] == 'global' and > ...and please add a test for the case of the bug report. I'd rather have the 'table' parameter accept un _RT_TABLE_ANY that skips this check, than skip it everytime we pass a device. Line 619: r['family'] == ('inet6' if family == 6 else 'inet')] Line 620: try: Line 621: gateway, = gateways Line 622: except ValueError: -- To view, visit http://gerrit.ovirt.org/37440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b8c789cf393fbb9aa9d040c38d2c9d9f281864 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
